search

openwisp / django-netjsongraph

Network Topology Visualizer & Network Topology Collector
MIT License
141 stars 64 forks source link

update outdated requirement (django-rest-framework) #17

Closed nemesifier closed 7 years ago

nemesifier commented 7 years ago

update and test outdated requirement (django-rest-framework).

rohithasrk commented 7 years ago

Porting into the latest version of django-rest-framework?

nemesifier commented 7 years ago

Yes, we should update the minimum version in the requirements file and run the tests

rohithasrk commented 7 years ago

@nemesisdesign What shall we set the minimum version to? 3.4? I'm not so clear about how we can figure out the minimum version.

nemesifier commented 7 years ago

@rohithasrk leave the minimum version unchanged, put a higher maximum version.

You have to do it here: https://github.com/netjson/django-netjsongraph/blob/master/requirements.txt

Because that file is read by the setupy.py script: https://github.com/netjson/django-netjsongraph/blob/master/setup.py#L45

Please run the test suite on your local clone with the latest drf version first, to check if there is any error.