Provide base classes to improve reusability by third party apps

openwisp / django-netjsongraph

Network Topology Visualizer & Network Topology Collector

MIT License

141 stars 64 forks source link

Provide base classes to improve reusability by third party apps #26

Closed rohithasrk closed 7 years ago

rohithasrk commented 7 years ago

This PR references #24. As of now, this just has an init commit for everyone to keep track of the work.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling d4717328f98cff97db344d8fabbbcfbc8acdccbc on rohithasrk:base-classes into da628eeef32488dc9b38d9607f91d20d31a5890f on netjson:master.

rohithasrk commented 7 years ago

This passes all the tests but there are some minor things I've noticed,

get_random_string function has been moved to utils.py but hasn't been removed from base/topology.py because importing from utils is creating some recursive import errors.
- Not much changes have been done to the base models as they already seem reusable.
- There might be some other issues that I might have overlooked. Your reviews are requested @nemesisdesign

nemesifier commented 7 years ago

next steps:

base API views
draft in docs

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 04d74c838768676ffc91ba1dcae726b7eb7162d3 on rohithasrk:base-classes into da628eeef32488dc9b38d9607f91d20d31a5890f on netjson:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling e65c30ddcefee147de8bc64e7921f0e2110716cc on rohithasrk:base-classes into da628eeef32488dc9b38d9607f91d20d31a5890f on netjson:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 6244f7acf3efcadc1b6dec7ce0e8c460ca220094 on rohithasrk:base-classes into da628eeef32488dc9b38d9607f91d20d31a5890f on netjson:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 797eaf7398fff9e853d19749cd0ca09ad9ee1195 on rohithasrk:base-classes into da628eeef32488dc9b38d9607f91d20d31a5890f on netjson:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling a6eb7518edefe61abb8864af2b42606fd6dcc430 on rohithasrk:base-classes into da628eeef32488dc9b38d9607f91d20d31a5890f on netjson:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 3720e1b2e0b1d7a51e94068fa049a97346ce34d4 on rohithasrk:base-classes into da628eeef32488dc9b38d9607f91d20d31a5890f on netjson:master.