search

openwisp / django-rest-framework-gis

Geographic add-ons for Django REST Framework. Maintained by the OpenWISP Project.
http://openwisp.org
MIT License
1.09k stars 201 forks source link

added django 2.2 on test matrix #190

Closed auvipy closed 5 years ago

jieter commented 5 years ago

It would be really nice to get explicit support for django 2.2, this is one of the few packages preventing upgrade to django==2.2.

auvipy commented 5 years ago

yes started work on that. could you review and suggest some edits to fix the errors? I will push them

jieter commented 5 years ago

I'm not really familiar with this code base, but I would not expect the existing environments (like py36-django111) to break on changing the CI config.

auvipy commented 5 years ago

ok, thanks for your time. I will need some more time to fix the issues myself.

Amertz08 commented 5 years ago

I want to +1 this PR as we're vetting a migration to Django2.2 and like @jieter it appears to be one of our dependencies that we're not sure if is g2g.

auvipy commented 5 years ago

will fix this soon

Amertz08 commented 5 years ago

Thanks @auvipy

auvipy commented 5 years ago

/test/testcases.py", line 454, in assertContains self.assertTrue(real_count != 0, msg_prefix + "Couldn't find %s in response" % text_repr) AssertionError: False is not true : Couldn't find '"type": "Point"' in response

nemesifier commented 5 years ago

maybe something has changed in DRF and the widget needs to be updated, that's my hypothesis

chris48s commented 5 years ago

I'm not deeply familiar with this package, but having had a quick look at it, is there something the wrong way round in the tests? If we look at

https://github.com/djangonauts/django-rest-framework-gis/blob/736f1566f8107d6376dfd83abee9e72b146b60f7/tests/django_restframework_gis_tests/tests.py#L481-L497

we're skipping 

test_geojson_HTML_widgetvaluepre_drf_39()
when not is_pre_drf_39 which seems like something is at least named incorrectly. Is the wrong test being run against the wrong version?

..but then also, since https://github.com/djangonauts/django-rest-framework-gis/commit/736f1566f8107d6376dfd83abee9e72b146b60f7 it looks like only one test is now needed here anyway.