openwisp / django-rest-framework-gis

Geographic add-ons for Django REST Framework. Maintained by the OpenWISP Project.
http://openwisp.org
MIT License
1.09k stars 201 forks source link

[fix] Avoid default_app_config Deprecation Warning in Django >= 3.2 #268

Closed bluppfisk closed 2 years ago

bluppfisk commented 2 years ago

This will stop Django 3.2 and higher from raising Deprecation Warnings because default_app_config is no longer necessary and will be removed in 4.1. Note that it breaks backward incompatibility with Django < 3.2 so it should only be used in releases dropping <3.2 support.

Yes, It may be a bit early for this one :)

bluppfisk commented 2 years ago

done :)

auvipy commented 2 years ago

please check the build failures

auvipy commented 2 years ago

Please read our guidelines at: http://openwisp.io/docs/developer/contributing.html#commit-message-style-guidelines ERROR: Commit message check failed! Checked commit message:

bluppfisk commented 2 years ago

ok tried my best :)

auvipy commented 2 years ago

I had to fixed a merge conflict, can you please pull & run flake8 check and push again?

auvipy commented 2 years ago

Your commit message does not follow our commit message style guidelines:

Please read our guidelines at: http://openwisp.io/docs/developer/contributing.html#commit-message-style-guidelines Checked commit message:

[fix] flake8 formatting ERROR: Commit message check failed!

auvipy commented 2 years ago

strange, it was green in the PR & showing failure after merge!

bluppfisk commented 2 years ago

Not sure why. The QA checks seem very strict for this project. Not necessarily a bad thing, but it looks like it thinks I've mentioned a particular issue (I didn't) and is angry at me for not mentioning that it is fixed in this PR. At least the code should work fine.

nemesifier commented 2 years ago

The problem was fixed in #270 and it was not a strictly QA check issue as far as I understood. @bluppfisk QA checks enforce consistency, we do this across all openwisp modules and it helps maintainers like me to maintain a lot of different packages faster because I can find things more easily.

batisteo commented 2 years ago

Would it be possible to have a minor release with this fix? :pray: