search

openwisp / django-rest-framework-gis

Geographic add-ons for Django REST Framework. Maintained by the OpenWISP Project.
http://openwisp.org
MIT License
1.08k stars 200 forks source link

[fix] Added missing float type to InBBoxFilter schema #277

Closed astanishevskyi closed 2 months ago

astanishevskyi commented 2 years ago

Fix typing in InBBoxFilter and DistanceToPointFilter. The only possible values for type are ['array', 'boolean', 'integer', 'number', 'object', 'string']. But float can be used as format of number.

Refarence to Swagger Documentation Data Types

auvipy commented 2 years ago

thanks for the patch. I have started the CI

astanishevskyi commented 2 years ago

@nemesisdesign thank you, fixed

auvipy commented 2 years ago

its still failing

nemesifier commented 2 years ago

@nemesisdesign thank you, fixed

I meant to amend the commit message with the text I indicated and force push it, eg:

git commit --amend
git push origin master
astanishevskyi commented 2 years ago

@nemesisdesign oh, sorry. Now fixed for sure

nemesifier commented 2 months ago

I had forgot about this one.

auvipy commented 1 month ago

I don't know If my merge privilege was revoked non intetionally or not.