openwisp / django-rest-framework-gis

Geographic add-ons for Django REST Framework. Maintained by the OpenWISP Project.
http://openwisp.org
MIT License
1.07k stars 200 forks source link

Allow geometry-less models #285

Closed 3nids closed 5 months ago

3nids commented 11 months ago

A null geometry is returned in such case

Fixes #282

3nids commented 11 months ago

Thank for the feedback! I added some tests. May I ask why running the test workflow requires an approval? It would ease the process to have a quicker feedback. Cheers.

auvipy commented 11 months ago

api.py", line 150, in pass_env_post_process raise Fail(msg) tox.tox_env.errors.Fail: passenv values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'TRAVIS TRAVIS*' Error: Process completed with exit code 1.

3nids commented 11 months ago

I made something wrong with my last force push, trying again.

auvipy commented 11 months ago

hope this will be green this time!

3nids commented 11 months ago

Looks like I didn't run makemigrations. hopefully I'll be back...

3nids commented 11 months ago

I don't understand what's the problem, may I ask your help @auvipy ?

3nids commented 10 months ago

ping @auvipy

3nids commented 10 months ago

This time, I don't think I'm responsible of the failure... image

3nids commented 10 months ago

@auvipy could you trigger the CI again please?

auvipy commented 10 months ago

Done

3nids commented 10 months ago

@auvipy thanks...one more try.

3nids commented 10 months ago

I haven't touched anything in tox.ini, quite strange. But I was wondering why there was some reference to TRAVIS variables in it? remains from the past? Maybe this needs to be dropped?

3nids commented 10 months ago

done, thanks!

3nids commented 10 months ago

gentle ping to trigger the CI....

3nids commented 6 months ago

would it be possible to retrigger the tests?

nemesifier commented 6 months ago

Triggered @3nids

3nids commented 6 months ago

@nemesifier thanks to the help from @suricactus this should be good now. That'd be great to re trigger the tests! Cheers!

suricactus commented 6 months ago

@3nids this makes all tests to pass locally. Forgot to commit last time: https://github.com/3nids/django-rest-framework-gis/pull/2

3nids commented 6 months ago

@nemesifier thanks again, should be good this time 🤞

3nids commented 5 months ago

ping @nemesifier

3nids commented 5 months ago

@nemesifier @suricactus I just dropped the 2 is not None and pushed. Could you retrigger the tests? cheers!

3nids commented 5 months ago

@nemesifier gentle ping :)