search

openwisp / django-rest-framework-gis

Geographic add-ons for Django REST Framework. Maintained by the OpenWISP Project.
http://openwisp.org
MIT License
1.07k stars 200 forks source link

[ci] Move QA checks as last step #289

Closed nemesifier closed 10 months ago

3nids commented 10 months ago

another approach would be to have separate jobs for the QA checks than the unit tests. Therefore everything is run in any case.

nemesifier commented 10 months ago

another approach would be to have separate jobs for the QA checks than the unit tests. Therefore everything is run in any case.

Yes, we can do that, also because there's no need to run the QA checks on all the python/django combinations, we can run the QA checks just once.

Now the problem are those test failures which I do not understand where are coming from.

3nids commented 10 months ago

Yes, we can do that, also because there's no need to run the QA checks on all the python/django combinations, we can run the QA checks just once.

Yes!

Now the problem are those test failures which I do not understand where are coming from.

apparently, this will be fixed here https://github.com/openwisp/django-rest-framework-gis/pull/288