[fix] Fixed render issue in popup page #113

openwisp / django-x509

Reusable django app implementing x509 PKI certificates management

http://openwisp.org

BSD 3-Clause "New" or "Revised" License

340 stars 69 forks source link

[fix] Fixed render issue in popup page #113 #114

Closed niteshsinha17 closed 3 years ago

niteshsinha17 commented 3 years ago

@nemesisdesign Before writing tests I wanted to show the implementation. Is it ok? I will need to use selenium in the test.

closes #113

coveralls commented 3 years ago

Coverage remained the same at 99.279% when pulling ae2aef043a80919d7d61ae299cca466b9a383fed on niteshsinha17:issues/113-render-issue-in-popup-page into 9b3795ec07ceee4bdd27e99b08424d048cbf05c7 on openwisp:master.

niteshsinha17 commented 3 years ago

Wait, noticed a problem, when I try to create a new CA from from certificate's add form, I don't get the option to select if I want create new or import. This change should only affect the change page! 😄

@atb00ker Thanks for spotting this. I have fixed it. Please check.