[WIP] Support Python 3.8 / Django 3

openwisp / django-x509

Reusable django app implementing x509 PKI certificates management

http://openwisp.org

BSD 3-Clause "New" or "Revised" License

340 stars 69 forks source link

[WIP] Support Python 3.8 / Django 3 #64

Closed takkaria closed 4 years ago

coveralls commented 5 years ago

Coverage decreased (-0.03%) to 98.898% when pulling 275134d94d9182dc3fb1ae5cd66ade571475acc2 on takkaria:patch-1 into bc7de60874607af8b49efce697e49a9942c75f17 on openwisp:master.

takkaria commented 5 years ago

I was hoping that it would be straightforward to upgrade to Django 3, but apparently not. I'll fix the issues and add the commits to the PR.

takkaria commented 5 years ago

So it looks like to support Django 3.0 we'd need to drop Python 2.7 support. That's because this package depends on django-model-utils which at the same time as being updated to support Django 3 is having Python 2 compatibility removed. Are you happy with that @nemesisdesign ? If so I will amend this PR when a new version of django-model-utils is released.

atb00ker commented 5 years ago

The title of the PR looks awesome, thanks @takkaria

About Python2.7 support, we intent to drop it, so I suppose this sounds about right! :smile:

takkaria commented 4 years ago

Closing as it looks like #70 is handling this pretty well.

nemesifier commented 4 years ago

@takkaria Thanks for contributing and closing the PR :+1: :+1: