Closed atb00ker closed 4 years ago
Drop support of python2 ?
As this is a reusable app, we shouldn't drop support of Python 2 now.
Oh, Got It Now ! Thank You :smiley:
The last release of django-x509 which supports python 2 will be 0.5.0, which I released a few days ago: https://github.com/openwisp/django-x509/releases/tag/0.5.0
We can prepare the next release to be python 3 only in order to support the newer versions of django.
PS: let's leave this for the Google Code-In.
Hello can I work on it ?
It's not in GCI system for now, adding it! :smile:
Here's Kind of summary
Some modules like six
, @python_2_unicode_compatible
has been removed in django3 or only supported for it's older vesrions (Older versions of Django)
Python3.5 Dosen't support Django3.0 so we have to exclude it in Travis right ?. Please tell me If I'm not right ! I will research more on it :smile:
All dependenices are up-to-date Requires.io:- https://requires.io/github/openwisp/django-x509/requirements/?branch=master except Django !
Is anything left please tell me :smile:
@IAmAMissingColon
For six, there are 2 possible solutions mentioned here, if it's a library that needs six
and you need alternatives for that library, please comment the name of the library here as well so that we can look for an alternative libraries as well. -- Since we are moving out of python 2, you might only need to remove the compatibility code. (read about six)
No, we are not dropping support for all other versions of Django, only adding support.
That's great! :smile:
Regarding jsonfield
, I just read : https://github.com/dmkoch/django-jsonfield/
Which makes this task a hard one I suppose! :smile:
@nemesisdesign What do you think? :smile:
Edit: Here is a maintained jsonfield project that should work: https://github.com/rpkilby/jsonfield2 Due to limited testing of this fork, we would need to add .travis tests for all the versions of django that we are supporting!
For Python, we should test python 3.6 and 3.7.
For the jsonfield we can use this one: https://github.com/rpkilby/jsonfield2 Looks like a fork of the one we're using, with the difference that is actually maintained.
I have taken this up so do I have remove support for python 2?
@Weirdo914 yes, you can remove python 2 support.
let's support only django 2.2.x and django 3.0.x, on python 3.6, 3.7 and you could try 3.8 as well.
The last python 2.7 compatible release with support for old django versions is 0.5.0.
@Weirdo914 please ensure to update the README accordingly.
We need to update all the dependencies including update to django 3.0