[bug] Publishing to container registry is broken

openwisp / docker-openwisp

OpenWISP in docker. For production usage we recommend using the ansible-openwisp2 role.

https://openwisp.io/docs/dev/docker/

BSD 3-Clause "New" or "Revised" License

149 stars 75 forks source link

[bug] Publishing to container registry is broken #272

Closed Bixilon closed 1 year ago

Bixilon commented 1 year ago

So, the latest commit (29d564a33f7364f9c5cff84be1fa9030f0ad24d0) fails:

Publishing to docker hub does not work, because of: denied: requested access to the resource is denied

Also publishing to gitlab container registry does not work (unauthorized).

I suggest the following things:

[ ] Make pipeline fail when publishing to docker hub fails
[ ] Fix docker hub publishing @nemesisdesign
[ ] Don't publish to gitlab container registry anymore (tha should then fix ci)
[ ] remove all references to gitlab container registry (docker compose, makefile, ...)

nemesifier commented 1 year ago

Closed by https://github.com/openwisp/docker-openwisp/commit/ef5284e3f58938981c3deaefc923f357221da569. We're not going to remove the gitlab registry because dockerhub has discontinued the free teams for open source project in favour of another open source offering which we need to apply for, but we already have a similar offering with gitlab which provides more features so we will most likely remove dockerhub at this point.

Bixilon commented 1 year ago

Then do that, instead of having docker hub images, people might be confused. Nobody looks at the gitlab registry if something is on docker hub.

nemesifier commented 1 year ago

Then do that, instead of having docker hub images, people might be confused. Nobody looks at the gitlab registry if something is on docker hub.

That's not an issue because the platforms where images are published is indicated in the README. As soon as we remove dockerhub images we'll update there, but let's focus on bringing this to a working state first we have limited bandwidth.