search

openwisp / netdiff

Python library for parsing network topology data (e.g.: OpenVPN, Wireguard, ZeroTier, NetJSON, Dynamic Routing Protocols) and detect changes.
MIT License
80 stars 37 forks source link

'metric cannot be None except when protocol is "static" #46

Closed nemesifier closed 4 years ago

nemesifier commented 7 years ago

Error messages like 'metric cannot be None except when protocol is "static"' do not make much sense when adding support to formats like OpenVPN.

NetJSON NetworkGraph is useful as a generic json graph format, so we should be less picky about these petty details.

We should remove this check and update the tests, ensuring test coverage does not decrease.