search

openwisp / netjsonconfig

Network configuration management library based on NetJSON DeviceConfiguration
https://netjsonconfig.openwisp.org/
Other
359 stars 71 forks source link

[fix] Fixed optional management frame protection #264 #267

Closed nemesifier closed 1 year ago

nemesifier commented 1 year ago

Closes #264

@pandafy this change here looks like a mistake, which I am fixing in this PR:

https://github.com/openwisp/netjsonconfig/commit/e696759a#diff-83e7f712c7b8a94dcf6a0acb84af4a1566db59ada5e3ecae57ab6f487ec93bd0L483-L485

The "optional" option was removed but the corresponding "enum_titles" was not. However, the section in the schema is named "encryption_mfp_property_optional" so it doesn't make a lot of sense to remove the possibility of setting MFP to "optional".

Let me know if you think that was not a mistake and give us more explanation.

coveralls commented 1 year ago

Coverage Status

Coverage: 98.658% (+0.3%) from 98.336% when pulling 2e7d5485f64ac2ecfe06d7c2a297bffa15ff5d95 on issues/264-mfp-optional into c4cdf682ed5c9d5bb2834aa43a51e5e6ab328389 on master.