search

openwisp / openwisp-config

OpenWRT configuration agent for OpenWISP Controller
https://openwisp.io/docs/dev/openwrt-config-agent/
GNU General Public License v3.0
374 stars 58 forks source link

[agent] Use configured curl timeout values in default test #121

Closed okraits closed 3 years ago

okraits commented 3 years ago

Otherwise it's possible that the test fails although the regular checksum fetch succeeds.

I had this issue because the overridden value 5 for --connect-timeout and --max-time was too low for the specific connection of the device.

In general it makes sense that the test behaves exactly like the regular checksum fetch.

okraits commented 3 years ago

@nemesisdesign I don't understand why Travis fails. I guess it's not related to this commit?

pandafy commented 3 years ago

@okraits the build is failing due to RST checks introduced in openwisp-utils 0.7.0, I have created a patch of fixing an error in README.rst. After #122 is merged, the build will not fail anymore.

okraits commented 3 years ago

@pandafy Ok, thank you for clearing this up!