search

openwisp / openwisp-config

OpenWRT configuration agent for OpenWISP Controller
https://openwisp.io/docs/dev/openwrt-config-agent/
GNU General Public License v3.0
374 stars 58 forks source link

[change] Remove unneeded ssl package implementation definitions #152

Closed feckert closed 2 years ago

feckert commented 2 years ago

@nemesisdesign @okraits Which ssl implementation is used by the openwisp-config agent is decided in the curl package. Currently, the wolfssl implementation is used here.

The openwisp-agent is not compiled servivce. Therefore, the division into different packages is not necessary. This commit removes all ssl package versions. There is now only one openwisp-config package.

This change is a result of the desire to integrate the openwisp-config as luci-app-openwisp into the LuCI repository. https://github.com/openwrt/luci/pull/5471

PS: openwisp monitoring is also affected by that change https://github.com/openwisp/openwrt-openwisp-monitoring/pull/78

feckert commented 2 years ago

We'll have to update the README and the docs too.

I can do that

I guess we have to recommend users to also installa an SSL library or the curl requests to any SSL HTTP endpoint will fail, or is SSL enabled by default now on OpenWrt?

@nemesisdesign From my point of view, that is not necessary. Since the ssl backend used for curl is set at compile time. And the current situation is that wolfssl is default used. Please see https://github.com/openwrt/packages/blob/master/net/curl/Config.in#L7.

nemesifier commented 2 years ago

We'll have to update the README and the docs too.

I can do that

Thank you very much.

I guess we have to recommend users to also installa an SSL library or the curl requests to any SSL HTTP endpoint will fail, or is SSL enabled by default now on OpenWrt?

@nemesisdesign From my point of view, that is not necessary. Since the ssl backend used for curl is set at compile time. And the current situation is that wolfssl is default used. Please see https://github.com/openwrt/packages/blob/master/net/curl/Config.in#L7.

Ok sounds good to me!

feckert commented 2 years ago

@nemesisdesign I have updated the documentation, and added only the change that creates only one package. I am now doing the same for openwisp-monitoring.

feckert commented 2 years ago

@devkapilbansal the last line doesn't look good?

Read-only file system. opkg_install_pkg: Failed to extract data files for ca-certificates. Package debris may remain! opkg_install_cmd: Cannot install package openwisp-config.

devkapilbansal commented 2 years ago

@devkapilbansal the last line doesn't look good?

Read-only file system. opkg_install_pkg: Failed to extract data files for ca-certificates. Package debris may remain! opkg_install_cmd: Cannot install package openwisp-config.

May be, there were some problems with my VM. I tried it on virgiin OpenWRT and it worked fine

nemesifier commented 2 years ago

Local testing went well, thank you @feckert @devkapilbansal :+1: