openwisp / openwisp-config

OpenWRT configuration agent for OpenWISP Controller
https://openwisp.io/docs/dev/openwrt-config-agent/
GNU General Public License v3.0
374 stars 58 forks source link

[fix] Verify downloaded tarball with configuration checksum #158 #159

Closed devkapilbansal closed 2 years ago

devkapilbansal commented 2 years ago

Closes #158

devkapilbansal commented 2 years ago

Instead of removing configuration checksum, shouldn't we replace it with persistent checksum 🤔

nemesifier commented 2 years ago

Instead of removing configuration checksum, shouldn't we replace it with persistent checksum thinking

The problem is that if the checksum is already present on the filesystem, the agent will not try to download the config at all because it assumes the config belonging to that checksum is already applied, so for that reason we have to remove any stored checksum, is it clear?