Fixes #224: Added ipv6 support to `openwisp-get-address`

openwisp / openwisp-config

OpenWRT configuration agent for OpenWISP Controller

https://openwisp.io/docs/stable/openwrt-config-agent/

GNU General Public License v3.0

374 stars 59 forks source link

Fixes #224: Added ipv6 support to `openwisp-get-address` #225

Closed Bartosz-lab closed 1 month ago

Bartosz-lab commented 1 month ago

Checklist

[x] I have read the OpenWISP Contributing Guidelines.
[x] I have manually tested the changes proposed in this pull request.
[ ] I have written new test cases for new code and/or updated existing tests for changes to existing code.
[x] I have updated the documentation.

Reference to Existing Issue

Fixes #224.

Description of Changes

Added support for getting the IPv6 address if the IPv4 address is not found in openwisp-get-address.

Bartosz-lab commented 1 month ago

Currently, the --prefer-ipv6 flag is not used anywhere in the code, but in the future, we may introduce a configuration option that would allow users to choose this preference. However, if we decide not to introduce this option, I will remove the flag.

nemesifier commented 1 month ago

Currently, the --prefer-ipv6 flag is not used anywhere in the code, but in the future, we may introduce a configuration option that would allow users to choose this preference. However, if we decide not to introduce this option, I will remove the flag.

As a general rule we add only code which is used. OpenWISP has quite a good number of modules which sums up as many lines of code, maintained by a very small group of people, so we need to make sure to add only what we really need. The problem is not just adding new lines of code but maintaining them over time.

Bartosz-lab commented 1 month ago

I have made the modifications to include only the necessary code.

nemesifier commented 1 month ago

Thanks @Bartosz-lab :pray: