openwisp / openwisp-controller

Network and WiFi controller: provisioning, configuration management and updates, (pull via openwisp-config or push via SSH), x509 PKI management and more. Mainly OpenWRT, but designed to work also on other systems.
https://openwisp.io/docs/dev/controller/
Other
556 stars 182 forks source link

[bug] Validation for name field broken #217

Closed nemesifier closed 4 years ago

nemesifier commented 4 years ago

How to replicate:

Expected result:

Actual result:

We need a regression test for this.

I would take advantage of this chance to add a help_text to the name field like the following: Will be used as hostname (must be a valid hostname).

NoumbissiValere commented 4 years ago

@nemesisdesign this issue was cause by the absent of the device_name_validator in the name field of Device model on the master branch. But this has been resolved here https://github.com/openwisp/openwisp-controller/blob/atb00ker-gsoc2020/openwisp_controller/config/base/device.py#L28.

So, I think we should close this issue and wait for atb00ker-gsoc2020 branch to be merged to master or do you still want that submit a Fix for it?

nemesifier commented 4 years ago

@NoumbissiValere no it's ok, thanks

nemesifier commented 4 years ago

Confirm that was fixed in the latest master, thanks @NoumbissiValere @atb00ker :+1: