[bug] Resolve bug and implement feature related to subnet division #842

openwisp / openwisp-controller

Network and WiFi controller: provisioning, configuration management and updates, (pull via openwisp-config or push via SSH), x509 PKI management and more. Mainly OpenWRT, but designed to work also on other systems.

https://openwisp.io/docs/dev/controller/

Other

550 stars 173 forks source link

[bug] Resolve bug and implement feature related to subnet division #842 #859

Closed praptisharma28 closed 3 months ago

praptisharma28 commented 4 months ago

Fixes #842

coveralls commented 4 months ago

coverage: 98.734% (-0.02%) from 98.75% when pulling 8fd94076ad049c99ba109a060600283fa492fed0 on praptisharma28:subnet into f0bdf03f1eba4c1ad484d9aa12f50f1481aa8bf4 on openwisp:master.

praptisharma28 commented 4 months ago

A test which replicates the bug is missing.

Okay @nemesifier will add.

nemesifier commented 3 months ago

While reviewing this PR I found out quite a few more issues with the code and I realized that the time I would have needed to explain everything was a lot higher than just fixing it myself so I went ahead and took this over.

@praptisharma28, please see my changes https://github.com/openwisp/openwisp-controller/pull/860 and ask questions for any part you don't understand.