openwisp / openwisp-controller

Network and WiFi controller: provisioning, configuration management and updates, (pull via openwisp-config or push via SSH), x509 PKI management and more. Mainly OpenWRT, but designed to work also on other systems.
https://openwisp.io/docs/dev/controller/
Other
550 stars 173 forks source link

[fix] Dealt with small subnets #842 #860

Closed nemesifier closed 3 months ago

nemesifier commented 3 months ago

Supersedes https://github.com/openwisp/openwisp-controller/pull/859.

Fixes #842

@pandafy @praptisharma28 please review.

coveralls commented 3 months ago

Coverage Status

coverage: 98.751% (+0.001%) from 98.75% when pulling 0883dfcf08fed5e470701be5132cf0f92b8d517b on issues/842-slash32-subnets into c4a1683da2810bca8163521ecfef54ce3454ac6d on master.

praptisharma28 commented 3 months ago

Supersedes #859.

Fixes #842

@pandafy @praptisharma28 please review.

I learnt a lot going through your PR. I initially tried to address the /32 subnet issue with a workaround, but I realize now that it wasn't the correct approach. I was too focused on simply preventing the error message without fully understanding the root cause and its implications.