[doc] updated commit guidelines #98

Kajol-Kumari commented 4 years ago

Fixes: #98 [docs] Make clear to have 1 PR for 1 feature

[x] updated contribution guideline for having the required number of commits per PR.

TravisBuddy commented 4 years ago

Travis tests have failed

Hey @Kajol-Kumari, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

openwisp-qa-check --skip-checkmigrations

``` SUCCESS: Blank endline check successful! Skipped 1 files SUCCESS: Isort check successful! All done! ✨ 🍰 ✨ 2 files would be left unchanged. SUCCESS: Black check successful! SUCCESS: Flake8 check successful! Your commit message does not follow our commit message style guidelines: - please add a capital letter after the prefix Please read our guidelines at: http://openwisp.io/docs/developer/contributing.html#commit-message-style-guidelines Checked commit message: [doc] updated commit guidelines #98 updated commit guidelines for having single commit per feature. Fixes #98 ERROR: Commit message check failed! File manage.py not found, skipping Make Migration Check. ```

TravisBuddy Request Identifier: e276ab10-04bd-11eb-a4bc-1b94c014fd22

devkapilbansal commented 4 years ago

Hey @Kajol-Kumari first letter of your commit message should be capitalized. Due to that, checks are failing.

atb00ker commented 4 years ago

Yes please, follow @devkapilbansal's advice and rebase to the current master. :smile:

Kajol-Kumari commented 4 years ago

@nemesisdesign @atb00ker please review this one.

nemesifier commented 4 years ago

Thanks

TravisBuddy commented 4 years ago

Hey @Kajol-Kumari, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

openwisp / openwisp-docs