Closed ManishShah120 closed 3 years ago
@nemesisdesign I have tested in my fork it is working fine. In order to take effect, this has to be merged into master.
@nemesisdesign I have tested in my fork it is working fine. In order to take effect, this has to be merged into master.
@ManishShah120 as you are a part of contributors
team, you should be able to create a branch on this repository itself instead of a fork. Create a new branch from master. Then you can merge and create a PR from that branch to master so that it can be tested.
@ManishShah120 as you are a part of
contributors
team, you should be able to create a branch on this repository itself instead of a fork. Create a new branch from master. Then you can merge and create a PR from that branch to master so that it can be tested.
Ok @devkapilbansal, then should I close this PR?
You can just create a new branch(say dev) from master and merge this PR to dev rather than closing it Then open a PR from dev to master
closes #131