[settings] Review OPENWISP_MONITORING_CHARTS and ADDITIONAL_CHARTS

openwisp / openwisp-monitoring

Network monitoring system written in Python and Django, designed to be extensible, programmable, scalable and easy to use by end users: once the system is configured, monitoring checks, alerts and metric collection happens automatically.

https://openwisp.io/docs/dev/monitoring/

Other

166 stars 115 forks source link

[settings] Review OPENWISP_MONITORING_CHARTS and ADDITIONAL_CHARTS #124

Closed PabloCastellano closed 4 years ago

PabloCastellano commented 4 years ago

The following settings may become useless after https://github.com/openwisp/openwisp-monitoring/pull/117 has been merged:

OPENWISP_MONITORING_CHARTS
ADDITIONAL_CHARTS

Check the following comments for context:

https://github.com/openwisp/openwisp-monitoring/pull/117#issuecomment-639828392
https://github.com/openwisp/openwisp-monitoring/pull/117#pullrequestreview-426132616

nemesifier commented 4 years ago

We concluded that register/unregister should be used to extend openwisp-monitoring when one needs to add custom funcionality., the settings instead should be used to change the default settings.