[change] Add timeout to all celery tasks

openwisp / openwisp-monitoring

Network monitoring system written in Python and Django, designed to be extensible, programmable, scalable and easy to use by end users: once the system is configured, monitoring checks, alerts and metric collection happens automatically.

https://openwisp.io/docs/dev/monitoring/

Other

165 stars 112 forks source link

[change] Add timeout to all celery tasks #474

Closed nemesifier closed 1 year ago

nemesifier commented 1 year ago

Let's ensure all tasks have a reasonable timeout.

Some tasks like run_checks must have a higher timeout (eg: 1 hour), we should avoid hitting this under all conditions, all the other tasks should have much shorter timeout but not too short.

uzaxirr commented 1 year ago

Hey, Can i take this up? My approach would be adding CELERYD_TASK_SOFT_TIME_LIMIT configuration option in celery configuration file. However can you please specify what should be the timeout value

pandafy commented 1 year ago

Hey @uzaxirr! This is a delicate change which requires prior experience with OpenWISP. I ask you to check "good first issues" on [OpenWISP Contributors Board]((https://github.com/orgs/openwisp/projects/3).