search

openwisp / openwisp-monitoring

Network monitoring system written in Python and Django, designed to be extensible, programmable, scalable and easy to use by end users: once the system is configured, monitoring checks, alerts and metric collection happens automatically.
https://openwisp.io/docs/dev/monitoring/
Other
166 stars 115 forks source link

[charts] Add way to register and unregister new chart configurations #86

Closed nemesifier closed 4 years ago

nemesifier commented 4 years ago

Just like we're doing in https://github.com/openwisp/openwisp-notifications/pull/19/files#diff-e4c93b8a95c5a88dcf0c7b41e5c5ff5fR1

nepython commented 4 years ago

Up for discussion

@nemesisdesign @PabloCastellano After this feature, OPENWISP_MONITORING_CHARTS seems a bit redundant to me, hence I suggest that we remove it. In case, I am missing anything, please correct me :)

PabloCastellano commented 4 years ago

@nepython I agree on removing ADDITIONAL_CHARTS but I think we can keep OPENWISP_MONITORING_CHARTS so that we don't need to call get_chart_configuration and check that the fields are correct every time. WDYT?

nepython commented 4 years ago

@nepython I agree on removing ADDITIONAL_CHARTS but I think we can keep OPENWISP_MONITORING_CHARTS so that we don't need to call get_chart_configuration and check that the fields are correct every time. WDYT?

I think, I didn't understand it fully. Please let me know if the current approach seems fine :smiley: +1 to not removing OPENWISP_MONITORING_CHARTS. I think it is still useful, use case: if the user wants to modify just one field in existing chart configuration, it seems more better approach.