openwisp / openwisp-notifications

Notifications module of OpenWISP
https://openwisp.io/docs/stable/notifications/
GNU General Public License v3.0
41 stars 42 forks source link

[bug] Notification sound file path is hardcoded #239

Closed pandafy closed 2 years ago

pandafy commented 2 years ago

The notification sound file path is hardcoded.

https://github.com/openwisp/openwisp-notifications/blob/6f880da13ca9a510e48e9cbd8f0d72ef150ea69c/openwisp_notifications/settings.py#L7-L11

Thus the notification sound does not work when a different static file storage backend is used.

Possible solution

We should wrap the file path in django.templatetags.static.static.