search

openwisp / openwisp-notifications

Notifications module of OpenWISP
https://openwisp.io/docs/dev/notifications/
GNU General Public License v3.0
41 stars 42 forks source link

[chores] Fix hardcoded URLs in test_api #75

Closed nemesifier closed 4 years ago

nemesifier commented 4 years ago

@pandafy always use reverse when generating URLs, I see there are some occurrences of hardcoded urls in test_api.py, if there are other occurrences fix those as well please.

pandafy commented 4 years ago

@nemesisdesign are you referencing to this https://github.com/openwisp/openwisp-notifications/blob/00ba08519e7bad41f9c0a8a20845ddd36ff2fa2a/openwisp_notifications/tests/test_api.py#L57-L60

or this? https://github.com/openwisp/openwisp-notifications/blob/00ba08519e7bad41f9c0a8a20845ddd36ff2fa2a/openwisp_notifications/tests/test_api.py#L53

nemesifier commented 4 years ago

@nemesisdesign are you referencing to this https://github.com/openwisp/openwisp-notifications/blob/00ba08519e7bad41f9c0a8a20845ddd36ff2fa2a/openwisp_notifications/tests/test_api.py#L57-L60

or this? https://github.com/openwisp/openwisp-notifications/blob/00ba08519e7bad41f9c0a8a20845ddd36ff2fa2a/openwisp_notifications/tests/test_api.py#L53

I'm referring to all occurrences of http://testserver/..., the former looks like one of those.