search

openwisp / openwisp-radius

Administration web interface and REST API for freeradius 3 build in django & python. Supports captive portal authentication, WPA Enerprise (802.1x), freeradius rlm_rest, social login, Hotspot 2.0 / 802.11u, importing users from CSV, registration of new users and more.
https://openwisp.io/docs/dev/radius/
GNU General Public License v3.0
360 stars 175 forks source link

[bug] FreeRADIUS PostAuthView returns 500 error #467

Open pandafy opened 1 year ago

pandafy commented 1 year ago

The FreeRADIUS PostAuthView (/api/v1/freeradius/postauth/) returns HTTP 500 error if the length of called_station_id field exceeds 50 characters.

A possible fix could be to update the PostAuthSerializer and set max_length attribute on the called_station_id field. This way, the view would return HTTP 400 with the error reason.

ujjwalkirti commented 1 year ago

@pandafy I want to work on this issue, can you assign this issue to me?

pandafy commented 1 year ago

@ujjwalkirti you can start working on this issue. You don't need to wait for someone to assign this issue to you, just an intent message is enough. 😄

I would recommend you to start by writing a failing test case before updating the serializer.

I would also recommend you to join the OpenWISP development chat.

nick2432 commented 8 months ago

can i start working on this?

pandafy commented 8 months ago

Yes @nick2432, go ahead! Don't forget to read my previous comments.

samirgorai commented 7 months ago

509

sumiran18 commented 1 month ago

I want to work on this issue , can you pls assign me this ?

nemesifier commented 1 month ago

Welcome @sumiran18! Create a PR first, then I'll assign it to you.

sanjeevholla26 commented 1 week ago

Can I work on this issue?