search

openwisp / openwisp-utils

Python and Django utilities shared between different openwisp modules
https://openwisp.io/docs/dev/utils/
BSD 3-Clause "New" or "Revised" License
74 stars 72 forks source link

[enhancement] Set body color explicitly #272

Closed atb00ker closed 2 years ago

atb00ker commented 2 years ago

When the theme of the system is dark, the site is forced to use the dark theme which we don't support, hence the dashboard looks ugly. We need to explicitly mention the color of the body to be white.

:root {}

(in openwisp.css) should fix the problem!

Aryamanz29 commented 2 years ago

I would like to work on this @atb00ker

atb00ker commented 2 years ago

Sure, please feel free to start with it! @Aryamanz29

atb00ker commented 2 years ago

My suggested solutions, including :root {} has problems. Please check and fix all the pages in a browser in dark mode before sending a PR! :smile:

Aryamanz29 commented 2 years ago

My suggested solutions, including :root {} has problems. Please check and fix all the pages in a browser in dark mode before sending a PR! 😄

I have used the same :root {} method and works perfectly fine with every page

BEFORE 📸

Screenshot (239)

Screenshot (244)

AFTER 📸

Screenshot (241)

Screenshot (246)

Aryamanz29 commented 2 years ago

My suggested solutions, including :root {} has problems. Please check and fix all the pages in a browser in dark mode before sending a PR! 😄

My suggested solutions, including :root {} has problems. Please check and fix all the pages in a browser in dark mode before sending a PR! 😄

I have used the same :root {} method and works perfectly fine with every page

I have added styles to base.html

Aryamanz29 commented 2 years ago

Hey @atb00ker, I have raised PR, Let me know any changes :smiley: