[chores] Upgrade drf-yasg~=1.21.0 #306

openwisp / openwisp-utils

Python and Django utilities shared between different openwisp modules

https://openwisp.io/docs/dev/utils/

BSD 3-Clause "New" or "Revised" License

74 stars 72 forks source link

[chores] Upgrade drf-yasg~=1.21.0 #306 #317

Closed sassy-bugs closed 1 year ago

sassy-bugs commented 2 years ago

Removed the workaround for DRF-yasg as described in #306 .

Changes

Removed the following workaround added in static file storage

openwisp-utils/openwisp_utils/storage.py

Screenshots

For UI changes, please share a screenshot

Checklist

[x] I have read the contributing guidelines.
[x] I have manually tested the proposed changes.
[ ] I have written new test cases to avoid regressions. (if necessary)
[ ] I have updated the documentation. (e.g. README.rst)
[ ] I have added [change!] to commit title to indicate a backward incompatible change. (if required)
[ ] I have checked the links added / modified in the documentation.

Closes #306

sassy-bugs commented 2 years ago

In my recent commit I have upgraded drf-yasg as described in the issue #306 I believe this commit will resolve this issue completely.

nemesifier commented 2 years ago

@sassy-bugs QA checks failing

nemesifier commented 2 years ago

@sassy-bugs please try doing git rebase -i HEAD~2 then squash the second commit, it will let you edit the commit message, you can use:

[chores] Upgrade drf-yasg~=1.21.0 #306

Removed the workaround for DRF-yasg.
Closes #306

nemesifier commented 2 years ago

@sassy-bugs ping

sassy-bugs commented 2 years ago

I'm sorry I have not been feeling well lately. Will follow your instructionsand do the needful by today. Thank you for being so patient with me Regards, Agrima

On Fri, 14 Oct, 2022, 7:46 pm Federico Capoano, @.***> wrote:

@sassy-bugs https://github.com/sassy-bugs ping

— Reply to this email directly, view it on GitHub https://github.com/openwisp/openwisp-utils/pull/317#issuecomment-1279069695, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXG6US4AYIEBWXG5JPBG7ITWDFTLXANCNFSM6AAAAAAQ3Z4ALU . You are receiving this because you were mentioned.Message ID: @.***>

nemesifier commented 2 years ago

@sassy-bugs ping

coveralls commented 1 year ago

Coverage decreased (-0.001%) to 98.654% when pulling d89275bfacd2ea23f564e12a142c1083d11966e2 on sassy-bugs:issues/306-upgrade-drf-yasg into bf1d7d780b249314256e56ea878440daf93ed47f on openwisp:master.

Aryamanz29 commented 1 year ago

@nemesisdesign I have rebased this branch and fixed the CI build.