[change] Status: if bridge member is not present as interface, remove it

openwisp / openwrt-openwisp-monitoring

OpenWRT monitoring agent for openwisp-monitoring

https://openwisp.io/docs/dev/openwrt-monitoring-agent/

GNU General Public License v3.0

23 stars 20 forks source link

[change] Status: if bridge member is not present as interface, remove it #83

Open nemesifier opened 2 years ago

nemesifier commented 2 years ago

When collecting device status from OpenWrt, the bridge member list may include members of interfaces which are not active.

Before adding the interface to the bridge members, it would be great to ensure the interface is present and active.

devkapilbansal commented 2 years ago

Hi @nemesisdesign, I think this issue is already taken care of in the past here

https://github.com/openwisp/openwrt-openwisp-monitoring/blob/42957e2bd1aa82b242dcb52924e84070802f5387/openwisp-monitoring/files/sbin/netjson-monitoring.lua#L128-L139

nemesifier commented 2 years ago

@devkapilbansal looks you're right, I am not sure why I created this then, let's leave it open for some more time and if I can't see this issue anymore at all I will close it.