search

openworm / OpenWorm

Repository for the main Dockerfile with the OpenWorm software stack and project-wide issues
http://openworm.org
MIT License
2.69k stars 212 forks source link

Construct the tap-withdrawal circuit within c302 #225

Closed slarson closed 7 years ago

slarson commented 8 years ago

@pgleeson requesting that we start collaborating on a google doc that defines the tap withdrawal circuit in detail. Let's be sure to link it here into this issue.

slarson commented 8 years ago

Notes from today's meeting with @raminmh and @lungd:

Work still ongoing with changing conductances to make the behavior correct.

lungd commented 8 years ago

I need to do some fine-tuning but I almost get the correct output.

slarson commented 8 years ago

Brilliant. Ready for a pull request?

On Thu, Dec 1, 2016 at 9:51 AM David Lung notifications@github.com wrote:

I need to do some fine-tuning but I almost get the correct output.

-

Separate activation of PLM and AVM

  Input current of 5pA
  [image: c302_twc_5pa]
  <https://cloud.githubusercontent.com/assets/5890526/20797634/f9e13a78-b7db-11e6-9f7a-7a283912ec2b.png>
  -

  14pA
  [image: c302_twc_14pa]
  <https://cloud.githubusercontent.com/assets/5890526/20797669/1bc9e89c-b7dc-11e6-882c-6fe24c6ff38f.png>
  -

Simultaneous activation

  5pA
  [image: c302_twc_5pa]
  <https://cloud.githubusercontent.com/assets/5890526/20797806/bec5f86a-b7dc-11e6-87a0-34ace0d12da1.png>
  -

  14pA
  [image: c302_twc_14pa]
  <https://cloud.githubusercontent.com/assets/5890526/20797812/c502d87e-b7dc-11e6-8918-d87c1cfc5be2.png>
  -

  PLM:5pA, AVM:14pA
  [image: c302_twc_plm-5pa_avm-14pa]
  <https://cloud.githubusercontent.com/assets/5890526/20797823/ccab8ba2-b7dc-11e6-9a73-e565f36b75fc.png>
  -

  PLM:14pA, AVM:5pA
  [image: c302_twc_plm-14pa_avm-5pa]
  <https://cloud.githubusercontent.com/assets/5890526/20797828/d122c920-b7dc-11e6-859c-6273dfea7fb2.png>

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openworm/OpenWorm/issues/225#issuecomment-264192349, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_VvKYuaENg85RJI5Zh4X8S1nKpJ1miks5rDt7WgaJpZM4KhiXT .

lungd commented 8 years ago

Let me edit/check my parameters a bit longer. I think I'll create a PR tomorrow or monday at the latest...

pgleeson commented 8 years ago

@lungd Looks good. Please merge in the recent changes to master before opening the PR. Also, can you make it so the use of your updated spreadsheet reader is an optional setting in c302.py, not the default, or all the existing generated networks will change. Thanks!

lungd commented 8 years ago

@pgleeson (@slarson) do you want me to create a PR for my c302.py changes first?

slarson commented 8 years ago

@lungd I think @pgleeson is saying to make sure you pull in his most recent changes he has made on the master branch and merge them in to your fork before you make the PR. This page should explain how to get the new changes in; then it will be up to you to do the merge where there may be any conflicts.

lungd commented 8 years ago

I was thinking about creating a PR only with the c302 changes I mentioned above, merging them into my fork after you have accepted and merged them into the original openworm project so I can create a PR only for the TW circuit (c302_TW and params file). I can also create a single PR with all the changes. As you like.

pgleeson commented 7 years ago

@lungd yes, it would be great if you could create a PR with just the main changes to c302.py etc. so these can be checked through, and then you can add one for the tap circuit.

lungd commented 7 years ago

First part: https://github.com/openworm/CElegansNeuroML/pull/74.

slarson commented 7 years ago

It was constructed. Future issues will focus on tuning it.