openworm / OpenWorm

Repository for the main Dockerfile with the OpenWorm software stack and project-wide issues
http://openworm.org
MIT License
2.55k stars 201 forks source link

Remove xubuntu-desktop installation #303

Closed mwatts15 closed 3 years ago

mwatts15 commented 3 years ago

Currently we are installing xubuntu-desktop Apt package in the docker image. This shouldn't be necessary since the docker image isn't providing a desktop environment. The installation of xubuntu-desktop should be removed and then the docker image can be rebuilt. Any failures that result from this can be handled by adding back any dependencies of xubuntu-desktop package that are actually needed to run.

pgleeson commented 3 years ago

This has been removed in both the python2 and python 3 versions in the development branch and both seem to be working... Testing appreciated.

clausagerskov commented 3 years ago

firstoutput.log

Ran build.cmd on the Dockerfile3 on Docker in Windows 10 x64 Pro with following output. Had to modify the DISPLAY variable to get a graphics window. doesn't seem to produce an mp4 though.

clausagerskov commented 3 years ago

Running build3.sh, run3.sh, works fine on Ubuntu 20.04 with Docker engine run.log

clausagerskov commented 3 years ago

error with ffmpeg in Windows is probably from me messing with the DISPLAY var

pgleeson commented 3 years ago

Great to hear. Thanks for testing @clausagerskov!

clausagerskov commented 3 years ago

Yep as I suspected, outputs videos with no problem on Windows if I don't mess with the master_openworm.py file

pgleeson commented 3 years ago

No longer installed in py3 dockerfile