search

openworm / OpenWorm

Repository for the main Dockerfile with the OpenWorm software stack and project-wide issues
http://openworm.org
MIT License
2.55k stars 201 forks source link

fix a build issue #316

Closed jia-kai closed 2 years ago

jia-kai commented 2 years ago

The python version in the container is too old to support the current gitpython (which needs at least python 3.7 due to its use of from __future__ import annotations).

This pull request will freeze the gitpython to be 2.1.15.

mwatts15 commented 2 years ago

Thanks, @jia-kai . It's better to install a specific version of gitpython rather than change the setup.py in this case just so there's no dependency on how the setup.py is structured. Can you amend this PR to do a pip install for 2.1.15 instead?

This does bring up the question of how and when we do version pinning in the Docker image. Maybe for Python we just need to have a requirements.txt for pip with frozen versions. There's a trade-off between the headaches of managing upgrades of every transitive dependency when needed vs having to deal with issues like this...probably we'll branch off for releases and freeze versions on the release branch for maintenance.

jia-kai commented 2 years ago

@mwatts15 Thanks for your suggestions. Using a separate pip install seems better. I've updated the PR.