search

openworm / geppetto-application

Sample Geppetto application
http://geppetto.org
Other
3 stars 1 forks source link

Completely port all Casper tests to Puppetter and Jest #14

Closed tarelli closed 4 years ago

tarelli commented 5 years ago

Following the prototype here finish porting all Casper tests of Geppetto application

filippomc commented 5 years ago

Hi @jrmartin are you planning to do all the tests? Maybe @afonsobspinto may take some!

jrmartin commented 5 years ago

@filippomc I was planning on doing them all, but the plan can change. What did you have in mind for splitting?

There's still lots of test to migrate from DefaultProjectsTests.js. All of PersistenceTests.js (with PersistenceTestsLogic.js) , NeuronalProjectsTests.js (with NeuronalTestsLogic.js), GeppettoModelTests.js and LiveTests.js.

Split proposal:

Whomever continues with DefaultProjectsTests.js, should probably also do NeuronalProjectsTests.js (with NeuronalTestsLogic.js), since the former also uses test functions from NeuronalTestsLogic.js. Maybe you @afonsobspinto can do this? Here are some instructions on how to start from Facundo https://github.com/openworm/org.geppetto.docs/blob/test-puppeteer/source/casper_tests.md . The branch we want to checkout for geppetto-application is 'test-puppeteer'.

I can take PersistenceTests.js (with PersistenceTestsLogic.js), GeppettoModelTests.js and LiveTests.js.

filippomc commented 5 years ago

@jrmartin seems a good plan! Thanks

tarelli commented 4 years ago

Done! Thanks @rodriguez-facundo @jrmartin @afonsobspinto