openworm / geppetto-application

Sample Geppetto application
http://geppetto.org
Other
3 stars 1 forks source link

Feature/geppetto client#35 #15

Closed jrmartin closed 5 years ago

jrmartin commented 5 years ago

Changes needed after dependency changes in openworm/geppetto-client#35 .

Build folder file output using CommonsChunkPlugin in webpack 3 vs using SplitChunksPlugin in webpack 4. (Webpack 3 CommonsChunkPlugin on Left vs Webpack 4 SplitChunksPlugin on Right) Screenshot from 2019-07-11 13-36-04 Main visible difference is that main.bundle.js got reduced and is now 11.2 kb instead of 6.65 MB and that common.bundle.js size increase and is now 7.26 mb instead of 1.69 mb.

After changing some settings in commit https://github.com/openworm/geppetto-application/pull/15/commits/38875627b4a3598d5d12405f7afbf53c0e77262c, the main.js and common.bundle.js are now similar size to what they were in webpack 3.

Passing travis test https://travis-ci.org/openworm/geppetto-application/builds/562163182

tarelli commented 5 years ago

@jrmartin I merged another PR first and this now has conflicts, can you resolve them?

jrmartin commented 5 years ago

@tarelli Conflicts have been resolved, passing https://travis-ci.org/openworm/geppetto-application/builds/562163182

filippomc commented 5 years ago

I tried it on windows with the last version of npm and the install worked. Couldn't go further due to a problem with the build in windows (see #19)

tarelli commented 5 years ago

@filippomc #18 seems unrelated?

filippomc commented 5 years ago

@tarelli yes it's a problem also with the development branch.

tarelli commented 5 years ago

I think this is the issue you are referring to https://github.com/openworm/geppetto-application/issues/19

afonsobspinto commented 5 years ago

Fixes #12 as well :+1: