Update Griddle to the latest version compatible with the react version used in the Geppetto codebase

openworm / geppetto-client

The web client of a Geppetto application

Other

4 stars 2 forks source link

Update Griddle to the latest version compatible with the react version used in the Geppetto codebase #21

Open ddelpiano opened 5 years ago

ddelpiano commented 5 years ago

as per title, update Griddle to the latest compatible with the react version used in the geppetto-client codebase.
Test ControlPanel component to ensure that the functionalities are preserved.
Test QueryBuilder component to ensure that the functionalities are preserved.
Test AdminPanel component to ensure that the functionalities are preserved.
Document the major changes have been done to switch from the old to the new version of Griddle in order to semplify the same operation for all the other applications that are using our Griddle fork (OSB, VFB and others).

tarelli commented 5 years ago

@ddelpiano after talking yesterday with @filippomc I'm wondering if this should happen by virtue of having all those components start using the listviewer Filippo is developing which will already be on the latest Griddle (which btw supports infinite scrolling), thoughts?

jrmartin commented 5 years ago

@filippomc Hey Filippo. I saw you updated griddle-react to version 1.13.1 as part of PR #48 . I'm also updating the dependency to the same version as part of this card, I already did but the casper tests are failing due to controlpanel.js still needing changes to make it work with griddle 1.13.1 https://travis-ci.org/openworm/geppetto-application/builds/556094254. Question, are you planning on making changes to controlpanel.js to make it compatible with griddle-react version 1.13.1 as part of PR #48 ? I'm working on the same, don't want to step in your toes if you are already taking care of the same issue.

filippomc commented 5 years ago

Hi @jrmartin I wouldn't waste time on the actual controlpanel only to update griddle: the api changed really much from 0.x to 1.x. There is also a plan to make a new control panel (see also #26) which will start from the new ListViewer coming from #41 .

jrmartin commented 5 years ago

@filippomc Alright, good to know . :thumbsup:

tarelli commented 5 years ago

We'll need to port the fixes to the new infinite scrolling plugin before we can do what @filippomc is proposing.

tarelli commented 5 years ago

@gidili knows what the fixes need to be