Open ddelpiano opened 5 years ago
@ddelpiano after talking yesterday with @filippomc I'm wondering if this should happen by virtue of having all those components start using the listviewer Filippo is developing which will already be on the latest Griddle (which btw supports infinite scrolling), thoughts?
@filippomc Hey Filippo. I saw you updated griddle-react to version 1.13.1 as part of PR #48 . I'm also updating the dependency to the same version as part of this card, I already did but the casper tests are failing due to controlpanel.js still needing changes to make it work with griddle 1.13.1 https://travis-ci.org/openworm/geppetto-application/builds/556094254. Question, are you planning on making changes to controlpanel.js to make it compatible with griddle-react version 1.13.1 as part of PR #48 ? I'm working on the same, don't want to step in your toes if you are already taking care of the same issue.
Hi @jrmartin I wouldn't waste time on the actual controlpanel only to update griddle: the api changed really much from 0.x to 1.x. There is also a plan to make a new control panel (see also #26) which will start from the new ListViewer coming from #41 .
@filippomc Alright, good to know . :thumbsup:
We'll need to port the fixes to the new infinite scrolling plugin before we can do what @filippomc is proposing.
@gidili knows what the fixes need to be