openworm / muscle_model

Model of C elegans body wall muscle based on Boyle & Cohen 2008
http://www.opensourcebrain.org/projects/muscle_model
Other
47 stars 24 forks source link

Write SciUnit validation tests for muscle_model #38

Open travs opened 9 years ago

travs commented 9 years ago

This issue can be closed when two tests of connectivity are implemented and incorporated into the test suite using SciUnit

gsarma commented 9 years ago

Can we re-open specific issues with the two tests that you described above? Just so that the issue names detail precisely what needs to be done.

rgerkin commented 9 years ago

@VahidGh @pgleeson Is the data here the experimental data from Fig 3A,B or the simulated data from Fig 3C,D?

rgerkin commented 9 years ago

@travs

I've started this here.

The first part looks more or less like what we have in ChannelWorm, except instead of loading it from the database I am loading it from the .csv files in the BoyleCohen2008/data directory. The same scale issue is apparent as in the corresponding ChannelWorm notebook.

The second part looks way off, and I'm not sure why. Unless I'm doing something wrong, the K channel model has rectification properties that it shouldn't have (in addition to the scale issue, which is more trivial). Possible things I could be doing wrong: simulating the wrong model somehow, computing currents at the wrong time point, ?

The third part is the beginning of a whole cell test, including voltage and calcium time courses, but I don't know what data to use to write a test for this.

VahidGh commented 9 years ago

@rgerkin, yes, in addition to this, in which you can find needed parameters like C_m, dense conductance, and e_rev for each channel.

rgerkin commented 9 years ago

@VahidGh "Yes" it is experimental data or "Yes" it is simulated data? Thanks for the link.

VahidGh commented 9 years ago

@rgerkin, The link in your comment, is experimental data. And the link addressed by me is simulated data.

pgleeson commented 9 years ago

The data here: https://github.com/openworm/muscle_model/tree/master/BoyleCohen2008/data seems like experimental data, but no info/notes associated with it.

I'd suggest first making sure their data matches the output of their matlab scripts before looking at the match to nml2 version. You could probably work with Rayner's python version too.

Note, the ca trace should work for the nml2 version (see https://github.com/openworm/ChannelWorm/issues/96#issuecomment-134233138), but note the K iv curve is for k_fast+k_slow, and there is no current way to get the total K current from the nml2 version (unless making 2 ivCurve analysis scripts and adding them)

slarson commented 7 years ago

Related issue: https://github.com/openworm/muscle_model/issues/64

slarson commented 7 years ago

Revisiting this today in the context of the scientific roadmap. Here are the steps that are required to close this off:

slarson commented 7 years ago

We need to sort out the topic of where the output objects from the notebooks will go once travis generates them. Previous they had been going into s3 but this may not be the best strategy going forward. (cc @rgerkin )