openworm / open-worm-analysis-toolbox

A testing pipeline that allows us to run a behavioural phenotyping of our virtual worm running the same test statistics the Schafer Lab used on their worm data.
Other
49 stars 27 forks source link

Write a unit test to validate that specifications match the WormFeatures object #93

Open MichaelCurrie opened 9 years ago

MichaelCurrie commented 9 years ago

As I am debugging the specifications one thing that is constantly coming up is discrepancies between how the features are described in the CSV files that the Specs class uses on the one hand, and the actual object heirarchy as stored in WormFeatures.

This issue can arise from both:

  1. WormFeatures instances instantiated from a NormalizedWorm instance, and
  2. WormFeatures instances created using the from_disk method.

Going forward, if someone adds an entry to the CSV file for a new feature, we'll have to be careful to check that they've also added this feature to the from_disk method, and also that they've added code to actually calculate the feature.

Athene-ai commented 3 years ago

I can contribute on this :)

mwatts15 commented 3 years ago

Pull requests are welcome

On Thu, Mar 11, 2021, 11:30 Daniela @.***> wrote:

I can contribute on this :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openworm/open-worm-analysis-toolbox/issues/93#issuecomment-796909412, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALLFSBQQ6EUMELQ3DGASKDTDD42LANCNFSM4AWSBCIA .

Athene-ai commented 3 years ago

Thanks :)

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Mail priva di virus. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Sat, 13 Mar 2021 at 06:58, Mark Watts @.***> wrote:

Pull requests are welcome

On Thu, Mar 11, 2021, 11:30 Daniela @.***> wrote:

I can contribute on this :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/openworm/open-worm-analysis-toolbox/issues/93#issuecomment-796909412 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AALLFSBQQ6EUMELQ3DGASKDTDD42LANCNFSM4AWSBCIA

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/openworm/open-worm-analysis-toolbox/issues/93#issuecomment-797842312, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANGYEVCNNY47TCHIATO7HILTDK5UDANCNFSM4AWSBCIA .