search

openworm / openworm_docs

Documentation for OpenWorm, i.e. docs.openworm.org
http://docs.openworm.org
44 stars 27 forks source link

skip daily gh-pages deployment #75

Closed casperdcl closed 3 years ago

casperdcl commented 5 years ago
pgleeson commented 3 years ago

Seems to be updating twice a day now: https://github.com/openworm/openworm_docs/blob/master/.github/workflows/mkdocs.yml#L6

Any need for this @mwatts15? Unfortunately the subprojects aren't changing that fast...

mwatts15 commented 3 years ago

I just picked that rate arbitrarily. I'm sure I can improve the skip logic. I'll look into it this weekend at the latest.

On Thu, Apr 8, 2021, 10:36 Padraig Gleeson @.***> wrote:

Seems to be updating twice a day now: https://github.com/openworm/openworm_docs/blob/master/.github/workflows/mkdocs.yml#L6

Any need for this @mwatts15 https://github.com/mwatts15? Unfortunately the subprojects aren't changing that fast...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openworm/openworm_docs/issues/75#issuecomment-815922879, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALLFSDWEUPEA4JPUAPVRKTTHXERFANCNFSM4JLYOKOQ .

mwatts15 commented 3 years ago

OK, so I did forget about this weekend before last, but still intending to address it.

mwatts15 commented 3 years ago

I added some logic to skip builds if repo metadata (.openworm.yml files) haven't changed and the master branch is the same as the last build. The build seems to be only updating for cause so far. I'll leave this for another day. If no unnecessary builds happen, I'll close.

pgleeson commented 3 years ago

@mwatts15 I've merged a PR to master and also made some commits directly to master, and the live page is not updating with any of the changes. Is the deployment only taking place if a .openworm.yml file has been changed?

mwatts15 commented 3 years ago

No, the logic of when to push is correct: we check if the branch is different from what's deployed and only skip if it's the same. Apparently, I was overwriting the updated site with a git stash I was doing. I was pushing from the wrong branch: I needed to checkout after ghp-import. I've fixed that bit.

pgleeson commented 3 years ago

Thanks @mwatts15 that looks like it resolved the deploy issue. It does still seem to be running the action to check 4 times an hour though. While it's just a brief run, it probably only needs to be done at most once a day.

mwatts15 commented 3 years ago

I reset it to hourly. I want a build often enough that repository metadata changes show up during the day.