search

openworm / org.geppetto.core

Geppetto core bundle
http://www.geppetto.org/
Other
23 stars 13 forks source link

allow resolve one import type #161

Closed mattearnshaw closed 4 years ago

mattearnshaw commented 5 years ago

need to finally get the branch mess sorted...

this one is easy, we need this one to avoid crashing frontend when resolving many paths. see

(there will be a corresponding geppetto-client PR)

tarelli commented 4 years ago

@mattearnshaw what's the latest with this?

mattearnshaw commented 4 years ago

@tarelli this should be fine to merge. the change in geppetto-client will come later

mattearnshaw commented 4 years ago

@tarelli actually I'm pretty sure this was intentional... you were (I think) suggesting to change batch size to 1 in the frontend (here), but at some point I modified this mechanism but kept the batching n=50 (will be part of the geppetto-client PR). Reason being I think because of a latency between client and server that adds up if making many requests in the frontend. Will try and confirm this with an example...

tarelli commented 4 years ago

@mattearnshaw so you don't need this right? if you are using batch = 50 definitely you don't need the other signature

mattearnshaw commented 4 years ago

@tarelli well this thinking was/is that it would still be needed. batch has always been 50, but when backend was using those batches the frontend would crash because "too much data was received at once". still testing this though...

tarelli commented 4 years ago

@mattearnshaw I don't follow why it would be needed, you can go down all the way to one if you want, why to have a different signature?