search

openworm / org.geppetto.core

Geppetto core bundle
http://www.geppetto.org/
Other
23 stars 13 forks source link

Extend schema to allow for a conversion service to be specified #55

Closed tarelli closed 9 years ago

tarelli commented 9 years ago

See below for an example:

<tns:entity>
     <tns:id>hhcell</tns:id>
     <tns:aspect>
        <tns:id>electrical</tns:id>
        <tns:simulator>
            <tns:simulatorId>jLemsSimulator</tns:simulatorId>
    <tns:conversionServiceId>NeuroMLConversionService</tns:conversionServiceId>
         </tns:simulator>
         <tns:model>
            <tns:modelInterpreterId>lemsModelInterpreter</tns:modelInterpreterId>
            <tns:modelURL>https://raw.github.com/openworm/org.geppetto.samples/master/LEMS/SingleComponentHH/LEMS_NML2_Ex5_DetCell.xml</tns:modelURL>
         </tns:model>
     </tns:aspect> 
</tns:entity>
adrianq commented 9 years ago

@tarelli At the moment when unmarshalling we are not validating the file/string with the schema (See https://github.com/openworm/org.geppetto.simulation/blob/master/src/main/java/org/geppetto/simulation/SimulationConfigReader.java). Is there any reason not to do so?

tarelli commented 9 years ago

@adrianq no, we should

adrianq commented 9 years ago

@tarelli I have created a PR for core and simulation bundles that implement the schema validation. I have added some comments to both of them. Please, read them carefully and if you want to discuss them more in detail just drop a line

adrianq commented 9 years ago

To bear in mind that if we finally merge this PR the Geppetto documentation needs to be updated as well.