search

openworm / org.geppetto.simulation

Generic simulation bundle for Geppetto
http://www.geppetto.org/
Other
9 stars 10 forks source link

fix "plot all recorded variables" issue #128

Closed mattearnshaw closed 6 years ago

mattearnshaw commented 7 years ago

fixes "plot all recorded variables" issue (https://github.com/OpenSourceBrain/geppetto-osb/issues/37) (cause = uninitialized experiment and project IDs returned, so frontend treats it as if variables for an external project were request)

to replicate issue:

  1. http://0.0.0.0:3000/projects/mainenetalpyramidalcell/models?explorer=https%253A%252F%252Fraw.githubusercontent.com%252FOpenSourceBrain%252FMainenEtAl_PyramidalCell%252Fmaster%252FneuroConstruct%252FgeneratedNeuroML2%252FOneComp.net.nml

  2. persist

  3. run -> record all at soma

  4. plot all recorded variables

  5. spinner activated/stops spinning but plot remains blank

mattearnshaw commented 7 years ago

added casper test to cover this https://github.com/openworm/org.geppetto.frontend/pull/629

mattearnshaw commented 6 years ago

@tarelli the travis config on this repo seems faulty – it's trying to checkout get-state-fix (the branch of this PR) from org.geppetto.model and org.geppetto.core, where it doesn't exist. not confident enough with travis stuff to fix this myself…

mattearnshaw commented 6 years ago

@tarelli I have pushed the solution we discussed yesterday, seems to work fine. I don't think it's necessary to save the ExperimentState objects – are they even stored at all? because before there was no problem if you reloaded after persisting, which suggests the ExperimentState objects are regenerated from something else, or at least that their experimentId and projectId fields are not stored.