Glitches in Development

[jrmartin]

• [x] Fix InfoModal to display info messages received from server
• [x] Fix ErrorModal to display error messages received from server
• [x] Remove loading spinner after info/error is displayed
• [x] Fix HelpModal, scrollbars not working properly
• [x] Fix Console glitches
• [x] Fullscreen button back on, but pressing it doesn't give us a fullscreen
• [x] Share bar icons cut in half, floating too much to the left

[jrmartin]

@mlolson Edit: Made card into more general testing one instead of just console error

[mlolson]

Hmm, that's odd I haven't seen that before. It almost looks like the stylesheet isn't loading. I wonder if the browser is cacheing an old version of something? Can you try opening it in incognito mode and see if that helps?

[jrmartin]

Just tried it in incognito mode, same behavior. I also tried it in firefox, after clearing cache and history. In firefox it also moves the controls button up and get to be a bit offscreen

[mlolson]

Are you seeing any errors in the console? It also looks like the font isn't loading, hmm

[jrmartin]

Uncaught TypeError: Cannot set property 'top' of undefined GEPPETTO.Console.js:198

The console resizing had some logic in some of the JS classes that were modifiied, some listeners making sure some CSS settings remained the same during resizing, most likely this is what's going on with the console.

[mlolson]

Oh this happening when you drag the console with your mouse. I didn't realize that was possible. I can reproduce this error when I do that. fwiw that also doesn't work on live.geppetto.org

[jrmartin]

Yeah, that's the only time it happens .Good catch, didn't notice it was happening on live too. Means the bug was introduced a while ago without anyone noticing. I'll take a look into it.

[mlolson]

I put in a couple commit that seem to fix that issue and the issue with the full screen editor. Let me know if things are working better.

On Fri, Aug 8, 2014 at 11:58 AM, Jesus M notifications@github.com wrote:

Yeah, that's the only time it happens .Good catch, didn't notice it was happening on live too. Means the bug was introduced a while ago without anyone noticing. I'll take a look into it.

— Reply to this email directly or view it on GitHub https://github.com/openworm/org.geppetto/issues/189#issuecomment-51643736 .

[jrmartin]

Cool. I also notice that we are lacking an InfoModal and ErrorModal component. I added them, but they are still not working as before. They used to be part of index.html, and were used to display different info and error messages received from the server. The sequence was server sends message -> GEPPETTO.GlobalHandler gets it -> GEPPETTO.FE is called to load info/error modal. There's other few errors, I added them to the top of this card.

Also, the MIT license must be added to all new classes.

[jrmartin]

@tarelli Tagging you to keep you on the loop.

[tarelli]

Also did the console go back to be behind the widgets?

[jrmartin]

@mlolson here's the font for simulation control buttong "font-family: "Helvetica Neue",Helvetica,Arial,sans-serif;"

[mlolson]

@tarelli It looks to me like the console is in front. Are you talking about plots and such?

[jrmartin]

@mlolson I see it in my machine too, console on top of widgets. I have a fix for it, but haven't committed. I will be committing later tonight, I see you finish the rest, we should be done with this card after that.

[mlolson]

Oh yes I see it now too. Thanks for fixing it :+1:

[mlolson]

@jrmartin let me know if you see any other problems, I will be online later this evening.