openworm / org.geppetto

Geppetto is an open-source platform to build web-based applications to visualize and simulate neuroscience data and models.
http://geppetto.org
Other
209 stars 50 forks source link

Browser freezes after reloading #202

Closed jrmartin closed 10 years ago

jrmartin commented 10 years ago

Steps to reproduce: 1 . Load simulation, wait for it to load

  1. Load another simulation

Not all the time, but very often, these steps will freeze the browser. Console points to LoadingSpiner modal, seems to be trying to get updated when it's not mounted yet.

loadingspinner

jrmartin commented 10 years ago

@mlolson Hey Matt, I assigned this bug to you since you are more familiar with what's going on when React components get mounted and unmounted.

mlolson commented 10 years ago

I'm seeing the error but I'm not able to crash the browser. That error is caused by callback functions being triggered on unmounted components, they shouldn't crash the browser. I wonder if the failure is due to a memory leak. I'm seeing the heap size climb up into the 130MB range when a second simulation is loaded.

jrmartin commented 10 years ago

Snap, deleted previous message by mistake. Seems likely it's a memory leak. In live it slows down for me a lot after loading another simulation, in localhost just freezes the browser, but that's probably due to less memory being available when running it locally.

jrmartin commented 10 years ago

Found the problem, and infinite loop in one of the widget controllers that wasn't an issue before.

tarelli commented 10 years ago

Great stuff Jesus! On Aug 17, 2014 12:33 AM, "Jesus M" notifications@github.com wrote:

Closed #202 https://github.com/openworm/org.geppetto/issues/202.

— Reply to this email directly or view it on GitHub https://github.com/openworm/org.geppetto/issues/202#event-153639934.