openworm / org.geppetto

Geppetto is an open-source platform to build web-based applications to visualize and simulate neuroscience data and models.
http://geppetto.org
Other
209 stars 50 forks source link

ConcurrentModificationException happening sometimes when running a simulation #209

Closed slarson closed 9 years ago

slarson commented 10 years ago

screenshot 2014-08-18 16 21 42

The graphs keep evolving in time but the 3D scene is stuck

Running Chrome Version 36.0.1985.143 on Macbook Air

jrmartin commented 10 years ago

Issue also present in LEMS in same machine https://github.com/openworm/org.geppetto/issues/213

Unable to reproduce in any browser in Windows 7.

@mlolson @gidili When you get a chance, could you test this issue and/or 213 in your Mac machines? I am unable to reproduce any of these errors in my windows machine and wondering if other machines also get it.

tarelli commented 9 years ago

Updated the title as @mlolson has just seen it happening with the LEMS sample so it's not about SPH particularly.

jrmartin commented 9 years ago

@mlolson Can you tell me what steps lead to the exception ? Did you have two tabs open running geppetto?

mlolson commented 9 years ago

@jrmartin I had one tab open and I loaded the LEMS simulation. There was nothing in the logs about it, we might want to add some functionality to log exceptions.

jrmartin commented 9 years ago

@mlolson Thanks. One more, was it in your localhost or live.geppetto.org?

mlolson commented 9 years ago

localhost

jrmartin commented 9 years ago

There's a fix for it already, just waiting confirmation on the lack of error to consider it done.

gidili commented 9 years ago

@jrmartin out of curiosity how was this resolved?

jrmartin commented 9 years ago

@gidili I joined the SimulationThread in the SimulationService. What was happenning SimulationThread and SimulationVisitor were sometimes making calls to simulate() at the same time, joining Simulation Thread inside SimulationServcie waits for that thread to finish before moving on to SimulationVisitor.