ConnectionNode issues - Githubissues

openworm / org.geppetto

Geppetto is an open-source platform to build web-based applications to visualize and simulate neuroscience data and models.

http://geppetto.org

Other

209 stars 50 forks source link

ConnectionNode issues #286

Closed tarelli closed 9 years ago

tarelli commented 9 years ago

From @adrianq

[x] customNodes are not sent to the server
[x] getChildren is not implemented for a ConnectionNode, it should return the custom nodes

tarelli commented 9 years ago

@jrmartin this should be a priority if you can get a chance so @adrianq is not blocked

adrianq commented 9 years ago

[x] Name property isn't sent to the client
[x] Custom Properties aren't sent to the client. Btw, shall custom properties be implemented by the Node class and extended by all the nodes?
[x] getChildren() is not implemented by ConnectionNodes. I guess the idea is that all nodes implement getChildren(). getChildren() may return all the children plus all the custom properties (assuming we implement custom properties for every single node)

tarelli commented 9 years ago

I don't think every node should have customNodes, doing something like that would be prone to abuses and would damage the abstraction as a whole. It would be easy for people to add things there "just bacause it's possible" and the next thing you know is that the code is a spaghetti of if statement checking if inside the custom nodes there is this one or that one thing.

adrianq commented 9 years ago

Ok, true... I was thinking more about sth like this https://github.com/openworm/org.geppetto/issues/269 My mistake..

jrmartin commented 9 years ago

Fix for this is in connection branch, needs pull on; core, simulation and frontend.

adrianq commented 9 years ago

@jrmartin after merging connection branch with neuromlpopulation branch I am having this error: [INFO] js: "/home/adrian/code/geppetto-code/org.geppetto.frontend/target/jsdoc3/jsdoc/jsdoc.js", line 316: exception from uncaught JavaScript throw: Error: ENOENT, no such file or directory '/home/adrian/code/geppetto-code/org.geppetto.frontend/src/main/webapp/js/GEPPETTO.js'

jrmartin commented 9 years ago

Doesn't like some js comments, not a big deal. You can comment out the jsdocs3 plugin from the pom.XML in the frontend, should solve it

tarelli commented 9 years ago

@jrmartin can we fix the culpable comments?

jrmartin commented 9 years ago

@tarelli They will, should be a fix within the next couple of commits

adrianq commented 9 years ago

@jrmartin @tarelli In the connection branch, TextMetadataNode.java has a "text" property and a "value" property (which comes from the AMetadataNode.java class). However the TextMetadataNode.js only has a "text" property and no "value" property. Obviously this is wrong but what should be the solution? Implement the "value" property for TextMetadataNode.js?

tarelli commented 9 years ago

@jrmartin @adrianq I think the text property is not needed and both Java and JS should use value which comes from the super class

adrianq commented 9 years ago

@jrmartin @jrmartin Ok, I am gonna fix it in neuromlpopulation branch

adrianq commented 9 years ago

@tarelli @jrmartin Shall getChildren for connectionnode return the VisualObjectReferenceNode as well?

tarelli commented 9 years ago

yes