Double display of cells when changing geometry type

openworm / org.geppetto

Geppetto is an open-source platform to build web-based applications to visualize and simulate neuroscience data and models.

http://geppetto.org

Other

209 stars 50 forks source link

Double display of cells when changing geometry type #519

Closed pgleeson closed 7 years ago

pgleeson commented 8 years ago

Before (on http://comodl.org/projects/thalamocortical?explorer=https%3A%2F%2Fraw.githubusercontent.com%2FOpenSourceBrain%2FThalamocortical%2Fmaster%2FneuroConstruct%2FgeneratedNeuroML2%2FLayer23_NoConns.net.nml):

selection_008

After running: Layer23_NoConns.setGeometryType('cylinders')

selection_007

i.e. all cells are shown again at (0,0,0) above existing net. Has been a problem for some time.

pgleeson commented 7 years ago

Still an issue in live version...

pgleeson commented 7 years ago

Seems to be fixed now in development/comodl. However the cells lose their colour:

selection_290

selection_289

tarelli commented 7 years ago

@jrmartin can we add a test in the casper Core suite to check that acnet2 doesn't loose the colour when switching to lines and then back to cylinders acnet2.setGeometryType("lines") acnet2.setGeometryType("cylinders")?

mattearnshaw commented 7 years ago

fix for loss of colours was merged