search

openworm / owmeta

Unified, simple data access python library for data & facts about C. elegans anatomy
MIT License
153 stars 50 forks source link

Travis-CI Test Build #447 introduced atexit._run_exitfuncs errors #215

Closed cheelee closed 9 years ago

cheelee commented 9 years ago

I just noticed starting from Build #447 (https://travis-ci.org/openworm/PyOpenWorm/builds/70450878), we've had every test's atexit call fail as follows:

Error in atexit._run_exitfuncs:

Traceback (most recent call last):

File "/opt/python/2.7.9/lib/python2.7/atexit.py", line 24, in _run_exitfuncs

func(*targs, **kargs)

File "./PyOpenWorm/init.py", line 114, in disconnect

if not m.connected:

AttributeError: 'module' object has no attribute 'connected'

travs commented 9 years ago

You're right, this output doesn't seem to affect the passing/failing of tests but something weird is definitely going on. Good catch @cheelee

travs commented 9 years ago

@kevcmk's #216 seems to fix this (or at least not flood the output with this text). If we can get the test numbers to match up we could potentially close this one.

cheelee commented 9 years ago

Yah, agreed. I've noted that all those post-test connection errors went away too. And I think that is because _DataTest isn't involved anymore.

cheelee commented 9 years ago

The test numbers match up. py.test is correct and our old test.py ended up generating 77 duplicate tests, whilst missing 12 tests that py.test caught. This is good. Thanks for the great feedback @travs and the awesome job using py.test @kevcmk . I'm closing this issue, and I think we can make that pull request merge official.

travs commented 9 years ago

@cheelee Awesome! Thanks for looking into this :)