openworm / owmeta

Unified, simple data access python library for data & facts about C. elegans anatomy
MIT License
152 stars 49 forks source link

owmeta install broken due to extra checks on Google downloads #474

Open pgleeson opened 1 year ago

pgleeson commented 1 year ago

The files specified here: https://github.com/openworm/owmeta-bundles/blob/master/index.json are all on GDrive, but recently(?) the download has changed to give a warning that they can't be scanned for viruses, e.g.

https://drive.google.com/uc?id=15JJcMyfgxtXsQp4GhmM-4c0ryi_RGph5&authuser=0&export=download

Seems this is a general issue: https://support.google.com/drive/thread/215627886/google-drive-scan-for-viruses-when-client-clicks-sharing-url?hl=en

@mwatts15 To get around this, I could manually download all the files and add them to the https://github.com/openworm/owmeta-bundles repo, updating the urls. How big is the largest of these? Would there be any issue with the hashes in the json file? Probably a better longer term solution than storing them on your drive.

mwatts15 commented 1 year ago

Padraig,

I can't pull up the list of files just now, but I think they're a few 100 KB at most. The hashes are of file contents, so they shouldn't change: would just need to update the URLs. I've no objection to relocating them.

On Thu, May 18, 2023, 09:54 Padraig Gleeson @.***> wrote:

The files specified here: https://github.com/openworm/owmeta-bundles/blob/master/index.json are all on GDrive, but recently(?) the download has changed to give a warning that they can't be scanned for viruses, e.g.

https://drive.google.com/uc?id=15JJcMyfgxtXsQp4GhmM-4c0ryi_RGph5&authuser=0&export=download

Seems this is a general issue: https://support.google.com/drive/thread/215627886/google-drive-scan-for-viruses-when-client-clicks-sharing-url?hl=en

@mwatts15 https://github.com/mwatts15 To get around this, I could manually download all the files and add them to the https://github.com/openworm/owmeta-bundles repo, updating the urls. How big is the largest of these? Would there be any issue with the hashes in the json file? Probably a better longer term solution than storing them on your drive.

— Reply to this email directly, view it on GitHub https://github.com/openworm/owmeta/issues/474, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALLFSDSR75MC3RNJUI5W43XGYZZFANCNFSM6AAAAAAYGSFLUY . You are receiving this because you were mentioned.Message ID: @.***>

pgleeson commented 1 year ago

Great, thanks. I'll do that so.

pgleeson commented 1 year ago

c302 tests are passing now with owmeta installed: https://github.com/openworm/c302/actions/runs/5022842688, but owmeta and owmeta-core tests are failing (possibly due to the versions of rdflib and urllib3, see https://github.com/openworm/owmeta-core/compare/develop_test?expand=1)

mwatts15 commented 1 year ago

Thanks, @pgleeson. GitHub didn't notify me when the owmeta-core develop branch build started failing last month. I'll get it going again.

pgleeson commented 1 year ago

@mwatts15 these are working fine now for c302, but the tests for owmeta are still failing. Any easy fix or is it a bit of work to get going again?

mwatts15 commented 1 year ago

I think it's relatively simple. I started working it, but I've been focused on a lot of other things lately.

On Mon, Jun 19, 2023, 11:49 Padraig Gleeson @.***> wrote:

@mwatts15 https://github.com/mwatts15 these are working fine now for c302, but the tests for owmeta are still failing. Any easy fix or is it a bit of work to get going again?

— Reply to this email directly, view it on GitHub https://github.com/openworm/owmeta/issues/474#issuecomment-1597483008, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALLFSFFPDQ55R2J4H7WMW3XMB7J3ANCNFSM6AAAAAAYGSFLUY . You are receiving this because you were mentioned.Message ID: @.***>